Repository navigation
Update Maven dependencies and fix expiration cutoff pre-filter - #154
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commons-lang3,commons-codec,slf4j,minio,azure-storage-blob,okhttp,jackson,jacoco-maven-plugin,maven-surefire-plugin,maven-failsafe-plugin,maven-compiler-plugin).AzureUtils.calculateExpirationCutoffandS3Utils.calculateExpirationCutoffwhereMath.max(0L, uploadExpirationPeriod - 2000L)clamped sub-2000ms expiration periods to0L, removing the 2000ms clock-skew safety margin and causing flaky test failures when the container clock is slightly ahead of the host JVM.AzureUtils.blobExists(BlobClient)and update unit tests inAzureUtilsTestandS3UtilsTest.Test Plan
mvn -P codestyle com.spotify.fmt:fmt-maven-plugin:format -q(0 reformatted).mvn clean install -q(all unit and integration tests passed).python3 scripts/check-coverage.py --per-file-limit 90(overall line coverage 98.30%,AzureUtils.java100.00%,S3Utils.java99.02%).